First Real Pull Request Ever

Embed Size (px)

Citation preview

  1. 1. My First Real Pull Request Ikuru K
  2. 2. What was it that I did? Christopher Wellons' (@skeeto) opengl demo did not run on my old machine. I created a patch that allows software rendering of the program for machines that have mesa 10.3.2
  3. 3. Flow of the story Read the interesting blog post and decided to try it on my machine. Git-clone'd the repo, ran the code and got initialization failed message.
  4. 4. Raised an Issue on Github
  5. 5. Got an immediate reply
  6. 6. Did as he suggested, and it worked!
  7. 7. Made a pull request so that environment var is set by make it self https://github.com/skeeto/opengl-demo/pull/4
  8. 8. Got a suggestion that I should also mention as such in README, so made another commit
  9. 9. @skeeto said he will merge my contribution if I squash the two commits together!
  10. 10. How I squashed commits Checked out head of @skeeto's master Did: merge squash And pushed to the branch that I have requested the pull
  11. 11. Merged! But...?
  12. 12. Resulting Commit After @skeeto adjustment https://github.com/skeeto/opengl- demo/commit/c2373b8d941c18bd3b4deaf438f4c60ff0df8e98
  13. 13. Lessons Learned Casually raising issues on Github is a nice thing that I do not need to be shy about. Proper commit messages are important, also for commits being squashed.
  14. 14. Thanks, especially to @skeeto for the valuable lesson!